Skip to content

Avoid making useless silence - #826

Merged
vincent-olivert-riera merged 2 commits into
line:masterfrom
hoangpn:feature/avoid_making_useless_silence
Nov 13, 2026
Merged

vincent-olivert-riera merged 2 commits into
line:masterfrom
hoangpn:feature/avoid_making_useless_silence

Conversation

@hoangpn

@hoangpn hoangpn commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

The current validations of Promgen's Silence creating/updating feature still have some defect. It allows normal Promgen users to make useless or ambiguous Silences that affect nothing on Promgen. Additionally, these Silences could cause problem to Alerts on Alertmanager that were not managed by Promgen.

This PR will add more validations to avoid those issues.

We have added a validation to SilenceSerializer to require meaningful "service" or "project"
matchers when users create a new Silence or update an existing one.
We have added a validation step requiring that Silence created by regular users must affect
at least one service or project on Promgen.

@vincent-olivert-riera vincent-olivert-riera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincent-olivert-riera
vincent-olivert-riera merged commit 71e57de into line:master Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants